BOFH
BOFH copied to clipboard
neuromancer
FHD screens: Double all screen sizes and adjust fade
bme: Double all screen sizes
The original screen size is definitely too small for all modern computers. For the standard FHD displays even quad size is required. The display zoom is implemented in a pretty static way so adding the quad size in addition to the double size is too cumbersome. So double all screen sizes instead.
bme: Increase the fade for quad size window
When switching from normal size to double size, which are now double and quad size, then there is not enough brightness any more. So do a color palette correction when switching between the modes. As a result of experimentation, a fade increase by 20 provides the best result for the quad size window.
@neuromancer Please review. TIA
Btw: I've just packaged BOFH for openSUSE and I want to add this fix. See: https://build.opensuse.org/package/show/home:TuxCheater:games/BOFH
Thanks a lot for your PR, @sriemer . I tested it and it works, however it still quite small for my notebook (I'm using 1920x1080). Can you make it adjustable according to the resolution?
(Also, keep in mind that I'm not the original author of this code, so my review skills are limited.)
The code is extremely limited. Keeping the config compatible was my priority. Adding further sizes requires a bigger redesign.
You’ve checked the interlaced mode and the double (quad) size mode by pressing F12 multiple times?
Original size is 320x240, double is 640x480, quad is 1280x960. Bigger does not fit on the screen. The zooming is implemented by copying pixels. 2x is 4 pixels per original pixel and 4x is 16 pixels per original pixel.
Oh, sorry, you are right, quad mode works great. Can we make it the default?
I've tried your proposal in a virtual machine. It crashes with a segfault in full screen mode if the screen size is too big. So I'd like to keep the default smaller. You basically only have to configure BOFH once and then it remembers your settings. The alternative would be fixing the segfault as well and auto switching to smaller size or printing an error or just changing the default of full screen to windowed mode. But that could be handled in another PR as well.