neurolib icon indicating copy to clipboard operation
neurolib copied to clipboard

Seed default parameter

Open lenasal opened this issue 3 years ago • 2 comments

Corrected the typo in the loadDefaultParameters.py file of the Hopf model. Previously, seed was set to 0 by default, which made the random numbers predictable, and resulted in the same simulation results repeatedly.

lenasal avatar Sep 20 '22 10:09 lenasal

@lenasal please correct failing tests thanks:)

jajcayn avatar Sep 20 '22 10:09 jajcayn

Codecov Report

Base: 94.96% // Head: 90.76% // Decreases project coverage by -4.20% :warning:

Coverage data is based on head (21fda9f) compared to base (0db88b5). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   94.96%   90.76%   -4.20%     
==========================================
  Files          51       51              
  Lines        4427     4374      -53     
==========================================
- Hits         4204     3970     -234     
- Misses        223      404     +181     
Flag Coverage Δ
unittests 90.76% <100.00%> (-4.20%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neurolib/models/hopf/loadDefaultParams.py 100.00% <100.00%> (+2.50%) :arrow_up:
neurolib/optimize/exploration/explorationUtils.py 28.75% <0.00%> (-50.42%) :arrow_down:
neurolib/optimize/evolution/evolutionaryUtils.py 47.80% <0.00%> (-32.08%) :arrow_down:
neurolib/optimize/evolution/deapUtils.py 89.25% <0.00%> (-10.75%) :arrow_down:
neurolib/utils/functions.py 75.96% <0.00%> (-0.45%) :arrow_down:
neurolib/models/multimodel/model.py 92.41% <0.00%> (-0.25%) :arrow_down:
neurolib/utils/parameterSpace.py 97.03% <0.00%> (-0.14%) :arrow_down:
neurolib/utils/signal.py 95.62% <0.00%> (-0.12%) :arrow_down:
neurolib/models/multimodel/builder/base/network.py 98.50% <0.00%> (-0.06%) :arrow_down:
neurolib/utils/stimulus.py 96.80% <0.00%> (-0.04%) :arrow_down:
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 20 '22 10:09 codecov[bot]