Manuel Thalmann

Results 114 comments of Manuel Thalmann

Not sure, tbh - I thought `ehanced-resolve` might be here for reasons. The console output of the `comparison-tests` reported less errors - no idea whether this means different output in...

I just gave it a go and it does work. However, I just read through this comment suggesting that the use of `enhanced-resolve` should be dropped completely. Especially for the...

Or we could just leave it as-is which will make it easier to implement `enhanced-resolve` or `this.getResolve` at a later point in time.

Currently, `enhanced-resolve` is disabled as per #1506 I will quickly set up a PR containing a (part-wise) re-enabled `enhanced-resolve` there, we should be able to see the differences in the...

The changes which happen when enabling `enhanced-resolve` (or a small number of cases), a few `comparison-tests` would change. You might want to have a look at it: https://github.com/TypeStrong/ts-loader/pull/1509

I think I found a solution, though, I'm not quite sure it's a valid one...? I added a `this.rl.pause()`-statement at the beginning and a `this.rl.resume()`-statement before the `resolve(...)` and it...

Though - when using this approach, lines are doubled: ```ts let result = await prompt( [ { type: "input", name: "food", message: "I have one more question for you! What's...

Though, I consider it a workaround, but this here works perfectly for me: ```diff import { createInterface } from "readline"; import { ReadStream } from "tty"; import { createPromptModule, InputQuestionOptions,...

@andrewbranch fyi Sorry, I made a little of a mistake in my last PR

@rbuckton Thank you so much for having a look through it 😄 I'll go test the new type declarations real quick to make sure it's really working this time