MRIcron icon indicating copy to clipboard operation
MRIcron copied to clipboard

New Debian release

Open neurolabusc opened this issue 2 years ago • 4 comments

@ghisvail would you be interested in updating and maintaining the Debian MRIcron package? I have tried to integrate comments from here. I am happy to assist, but do not have any Debian privileges. I have made numerous changes to the main source code that removes the need fro Debian specific patches. This should make future updates simpler.

  1. The code should be sourced from Github https://github.com/neurolabusc/MRIcron not http://www.mccauslandcenter.sc.edu/CRNL/sw/mricron/source.zip

  2. I would ensure that a recent version of libqt5pas is included. I think only the recent versions support accessibility features. I am not sure if this has been added to Debian trunk or not, I think the latest is 1.2.9: https://github.com/davidbannon/libqt5pas This will influence the micron control file depends: Depends: libqt5pas1, libc6 (>= 2.14), mricron-data (= )

  3. I would prefer the icon to be the svg instead of an xpm - I think the .Desktop file needs to be changed to reflect this: Icon=/usr/share/icons/hicolor/scalable/apps/mricron.svg

  4. I do not think any of the patches are required: I have tried to integrate them all into the common code for all Linux users (thanks to the work of the Debian community).

neurolabusc avatar Oct 02 '21 11:10 neurolabusc

The code should be sourced from Github

Ok, that can be changed easily by tracking GitHub releases in the d/watch file.

I would ensure that a recent version of libqt5pas is included.

Embedded dependencies are proscribed for official Debian packages. If an update to libqt5pas is required, then it should be tackled first.

I would prefer the icon to be the svg instead of an xpm.

Same. SVG is the norm now for scalable icons. Just use Icon=mricron to let the desktop environment pick the appropriate icon based on what's available.

I do not think any of the patches are required: I have tried to integrate them all into the common code for all Linux users (thanks to the work of the Debian community).

That's a good sign. I'll see what I can do.

ghisvail avatar Oct 02 '21 12:10 ghisvail

See https://github.com/neurolabusc/MRIcron/pull/19

ghisvail avatar Oct 02 '21 12:10 ghisvail

@ghisvail thanks for your quick work. To be clear, I do not think an update of libqt5pas is required: the software will need the same version or newer for the version of Lazarus used for compilation. So as long as it builds with Lazarus, you should be able to distribute this. However, this means the accessibility features of the widgets will be limited until a future version of Lazarus is released.

neurolabusc avatar Oct 02 '21 12:10 neurolabusc

@ghisvail I am happy to consider the current source code the next stable release (v1.2.20211006). Could you help me turn this into a proper Debian repository. It is very similar to the prior Debian release, but now uses QT5, the source code is hosted on Github, all the prior Debian-specific patches have been included into the main source code. The repository now contains a new folder called Debian that includes an SVG icon, new .Desktop file, and new control file. I realize you are busy, and if this is outside your scope just tell me and I will seek someone else as a maintainer. I do appreciate your work with dcm2niix, so would be grateful if you can help out.

neurolabusc avatar Oct 15 '21 20:10 neurolabusc