movement icon indicating copy to clipboard operation
movement copied to clipboard

Update integration tests

Open sfmig opened this issue 1 year ago • 2 comments

Description

What is this PR

  • [ ] Bug fix
  • [ ] Addition of a new feature
  • [x] Other

Why is this PR needed? Updates integration tests to match recent changes to kinematic tests. Also simplifies one of the integration tests and factors part of it out as a unit test.

What does this PR do?

  • Modifies test_cart2pol_transform_on_kinematics to better match the current kinematic tests (mainly to use datasets with easily derivable kinematics).
  • Split test_nan_propagation_through_filters into two tests:
    • an integration test that runs filter by confidence, SG filter and interpolation sequentially, and
    • a unit test (test_filter_with_nans_on_position_varying_window) that counts the number of nans stays below the expected upper bound when applying a median filter or SG filter.

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated.

Checklist:

  • [ ] The code has been tested locally
  • [ ] Tests have been added to cover all new functionality
  • [ ] The documentation has been updated to reflect any changes
  • [ ] The code has been formatted with pre-commit

sfmig avatar Aug 30 '24 19:08 sfmig

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.77%. Comparing base (bfb20d2) to head (e947f6c). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          15       15           
  Lines         909      909           
=======================================
  Hits          907      907           
  Misses          2        2           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 30 '24 19:08 codecov[bot]