hyppo
hyppo copied to clipboard
Test whether different types
Is your feature request related to a problem? Please describe.
Currently, methods in hyppo
cast the input values to a float
. While this is fine in most cases, it would be better to test if this restriction can be loosened to allow other types like int
and see if the unit tests still pass.
Describe the solution you'd like
The solution has 3 steps:
- [ ] Remove the float casting in
_CheckInputs
. See ifx
can bearray_like
like here: https://scipy.github.io/devdocs/reference/generated/scipy.stats.multivariate_normal.html?highlight=multivariate#scipy.stats.multivariate_normal. This involves changing all the input checks into something similar to what is in SciPy - [ ] See if unit tests still pass
- [ ] Change documentation to reflect if inputs are
array_like
Describe alternatives you've considered
Additional context (e.g. screenshots)
@darsh-patel This isn't enough for an NDD project. Didn't we talk last semester about cleaning up the goodness of fit module? And adding more tests?