add more robust unit tests to validate accuracy with other simulations

[sampan501]

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context (e.g. screenshots)

[sampan501]

tests against sinusodial sims, general nonlinear sims, etc.

[pragyasrivastava0805]

@sampan501 I am very new to open source.Could you please walk me through and tell me what exactly needs to be done?

[sampan501]

Hello, thank you for looking into this. If you look at the unit tests in the package, currently it only verifies if the test statistic and p-value are the same for a single simulation, whether Type I error is controlled, and if inputs are proper shapes. I think something like this would be good (similar code to here): 1D linear (we have), a nonlinear simulation, and independence (we have); 5D versions of all of them. Does that make sense?

[svshivapuja]

Hi can I work on this too ?

[sampan501]

sure!

[scfenton6]

Hi @sampan501 , since no prs have been submitted in a while for this issues, can I give it a shot?

[sampan501]

Are @svshivapuja or @pragyasrivastava0805 currently working on this?

[svshivapuja]

Sorry, I was caught up on other work. You can go ahead and pass on the work. Sorry again..