hyppo icon indicating copy to clipboard operation
hyppo copied to clipboard

Add the range of each independence test statistic to docs

Open CaseyWeiner opened this issue 4 years ago • 17 comments

I think MGC test statistic is in the interval [-1, 1] and the rest are [0,1]?

CaseyWeiner avatar Sep 14 '20 02:09 CaseyWeiner

Would I be correct in thinking this is probably the easiest issue on the list?

oakla avatar Feb 13 '22 22:02 oakla

yes, minor docstring edits

sampan501 avatar Feb 13 '22 23:02 sampan501

I'm on it. I've created a fork.

If I understand correctly, I'm suppose to link my pull request to this issue once i've finished coding the solution.

oakla avatar Feb 15 '22 01:02 oakla

I think MGC test statistic is in the interval [-1, 1] and the rest are [0,1]?

Can i assume these values are correct, or is it worth taking the time to verify it myself?

oakla avatar Feb 19 '22 08:02 oakla

Those aren't correct, most are [-1, 1] while some like HHG have no clear interval. I think it's worth taking time to verify, especially if you are learning a lot!

sampan501 avatar Feb 19 '22 14:02 sampan501

Can you please assign me this issue?

Kshitij2001 avatar Apr 27 '22 14:04 Kshitij2001

I've been working on and off this issue for a while. So I can submit some of my progress, can we break this issue into separate issues for each test?

oakla avatar Jun 20 '22 00:06 oakla

Yes we can. Can you make a new issue for the tests you have done and then open a PR linking to that issue?

sampan501 avatar Jun 20 '22 01:06 sampan501

I made a PR for one of the tests last week. There's been no comment on it yet

oakla avatar Aug 01 '22 00:08 oakla

Hi I'm currently out of the country and haven't reviewed any PRs made in the last week. I'll review them when I get back.

sampan501 avatar Aug 01 '22 00:08 sampan501