SPORF icon indicating copy to clipboard operation
SPORF copied to clipboard

Published 20 hours ago • verified publisher icon neurodata

fix string -> int

Open MrAE opened this issue 5 years ago • 4 comments

MrAE avatar Oct 02 '19 17:10 MrAE

Deploy preview for rerf ready!

Built with commit aa4f5a1e1b54b6361272dfdece7a9e51bb993b70

https://deploy-preview-336--rerf.netlify.com

netlify[bot] avatar Oct 02 '19 17:10 netlify[bot]

why did run time go up?

falkben avatar Oct 02 '19 19:10 falkben

The labels were strings. Not sure if it was running properly the first time.

MrAE avatar Oct 02 '19 19:10 MrAE

pybind11 may have been doing the conversion for us, but agree, this is better. but even better than this would be validation in the class itself to ensure that the class labels are integers, or to just convert them there.

On Wed, Oct 2, 2019 at 3:03 PM Jesse Leigh Patsolic < [email protected]> wrote:

The labels were strings. Not sure if it was running properly the first time.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/neurodata/SPORF/pull/336?email_source=notifications&email_token=AAE7NZ6VIAIN254QLYHEYXDQMTWAXA5CNFSM4I4ZJ4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAF2P4A#issuecomment-537634800, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE7NZ3VOKMWNFBLRJXZYLDQMTWAXANCNFSM4I4ZJ4GQ .

falkben avatar Oct 02 '19 19:10 falkben