SPORF icon indicating copy to clipboard operation
SPORF copied to clipboard

rename `binnedBaseTern` to something more general

Open MrAE opened this issue 5 years ago • 2 comments

As a quick-fix until we get a randMat class. @jovo @falkben @jbrowne6 My suggestions (ranked) are:

  1. binnedBaseProjection
  2. binnedBaseRandMat
  3. binnedBaseWeighted
  4. binnedBaseCustom

MrAE avatar May 22 '19 17:05 MrAE

up to you guys i think?

On Wed, May 22, 2019 at 1:48 PM Jesse Leigh Patsolic < [email protected]> wrote:

As a quick-fix until we get a randMat class. @jovo https://github.com/jovo @falkben https://github.com/falkben @jbrowne6 https://github.com/jbrowne6 My suggestions (ranked) are:

  1. binnedBaseProjection
  2. binnedBaseRandMat
  3. binnedBaseWeighted
  4. binnedBaseCustom

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/neurodata/RerF/issues/272?email_source=notifications&email_token=AAAKG4WUECMOKQDK65M4MLTPWWBLNA5CNFSM4HOWSY7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVIXGBA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAKG4XPBR25LR2RST3ST7DPWWBLNANCNFSM4HOWSY7A .

-- the glass is all full: half water, half air. neurodata.io

jovo avatar May 22 '19 18:05 jovo

i don't think we care what it's called in C++ as long as it's clear to us. binnedBaseTern seems fine to me

falkben avatar Jun 06 '19 21:06 falkben