ProgLearn icon indicating copy to clipboard operation
ProgLearn copied to clipboard

DOC fix typos & FIX modify python version for website builder

Open PSSF23 opened this issue 2 years ago • 6 comments

Reference issue

Close #546 Close #543

Type of change

Documentation, Website

What does this implement/fix?

  • Fix attribute name typos
  • Modify website build python version

Additional information

PSSF23 avatar Sep 06 '22 17:09 PSSF23

@PSSF23 what did you do about the MLKNN unit test?

jdey4 avatar Sep 14 '22 18:09 jdey4

@PSSF23 what did you do about the MLKNN unit test?

Nothing. Unrelated.

PSSF23 avatar Sep 14 '22 18:09 PSSF23

The unit tests seem to fail.

jdey4 avatar Sep 14 '22 18:09 jdey4

The unit tests seem to fail.

Yes. But it's not related to this PR. I made another issue #548 for that.

PSSF23 avatar Sep 14 '22 18:09 PSSF23

The unit tests seem to fail.

Yes. But it's not related to this PR. I made another issue #548 for that.

It's bad practice to merge PRs without all checks being passed! It will be better to possibly take out that unit test or use @pargma no cover to ignore the unit test.

jdey4 avatar Sep 14 '22 18:09 jdey4

Codecov Report

Base: 92.36% // Head: 88.54% // Decreases project coverage by -3.81% :warning:

Coverage data is based on head (0d1a7cf) compared to base (af84f50). Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging     #547      +/-   ##
===========================================
- Coverage    92.36%   88.54%   -3.82%     
===========================================
  Files            7        7              
  Lines          419      419              
===========================================
- Hits           387      371      -16     
- Misses          32       48      +16     
Impacted Files Coverage Δ
proglearn/forest.py 100.00% <ø> (ø)
proglearn/network.py 100.00% <ø> (ø)
proglearn/progressive_learner.py 87.00% <ø> (ø)
proglearn/voters.py 74.71% <0.00%> (-18.40%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 06 '22 14:10 codecov[bot]