neurobionics
Fixes for #479, #480, #481
#481 - This PR flattens the current JSON schema so that all values are logged under the "attributes" key instead of grouping values differently for variables and functions.
#480 - This PR fixes the current use of a hardcoded "variables.log" string, and instead uses the user-given string for the log file and uses this name for the JSON data file.
#479 - Currently, we set up the user-configured file at initialization. This is a problem in the open-source leg library, since we initialize a global logger, and the user might change their logging configuration, which can lead to empty and unused files. This PR fixes this by lazily creating the files.
Hey @unshrawal, sorry for the delay! Can you try resolving the conflicts? They probably occurred due to some recent changes to the library over the last month.
Hey @unshrawal can you remind me of the status of this? Are we just waiting for conflicts to be resolved?
Hey @tkevinbest, I think the only thing that's left is resolving the merge conflicts - unless y'all have found any more bugs within the new logger. I'll try to fix all of the merge conflict by the end of this week.