letsacme icon indicating copy to clipboard operation
letsacme copied to clipboard

Fixing display of error messages

Open light opened this issue 7 years ago • 3 comments

Fixes API error messages not being displayed properly due to method reference not being called.

light avatar Feb 25 '18 18:02 light

checks have failed for python 2.6, You can change the travis.yml file like this:

Change

install:
 - "pip install -r requirements.txt"
 - "pip install pylint"

To

install:
 - "pip install -r requirements.txt | true"
 - "pip install pylint | true"

neurobin avatar Feb 25 '18 20:02 neurobin

Ah, sorry I didn't realize that it would fail on 2.6. I don't think the fix you proposed would work, it would fail next when trying to run pylint. For build reproductibility versions of pylint and requirements should be pinned to known good ones, but I think this fix is out of scope for this PR.

light avatar Feb 27 '18 19:02 light

the above fix would actually work, because pylint error for 2.6 and 3.2 are already ignored for a different reason.

neurobin avatar Feb 28 '18 04:02 neurobin