Michel comments

Results 249 comments of


                                            Michel

Not clear when to call save() vs. saveAll() when updating a doc with relations

Yes, what you described for `schoolId` is spot on. Implementing solution 2 shouldn't be hard. Thanks for the feedback @mindjuice!

Not clear when to call save() vs. saveAll() when updating a doc with relations

You can create your app and save it first and the call use addRelation http://thinky.io/documentation/api/document/#addrelation

Not clear when to call save() vs. saveAll() when updating a doc with relations

For belongsTo you can directly pass the string to the foreign key. For `hasAndBelongsToMany`, you can also pass a value instead of a document (the value of the foreign key)...

Not clear when to call save() vs. saveAll() when updating a doc with relations

Also on a side not, I'm thinking about deprecating saving a `hasAndBelongsToMany` relations with values as there is now `addRelation`.

Not clear when to call save() vs. saveAll() when updating a doc with relations

1. You are misunderstanding `addRelation`. It doesn't create a new relation between two models, but a new relation between two documents. Typically if you have two saved documents A and...

Not clear when to call save() vs. saveAll() when updating a doc with relations

It doesn't really seem like a good idea mostly because it means that you can't easily create the opposite relation.

Lazily evaluate streams

A reasonable way to achieve that is to do something similar to `Changes`. We can start adding lazy methods for `r.range()`, and then move all the streams method to those.

Consider using Joi for schema validation

Yes, the current syntax is based on Joi. I don't remember who showed it to me, but I found the syntax way nicer that what we used to have. I...

Consider using Joi for schema validation

That being said, I'm not an expert on Joi and may have missed an option to skip validation in special cases (or they may have added it since last time?).

Consider using Joi for schema validation

It needs to skip validation sometimes (for ReQL terms like `r.now()`), or have a special handling for binaries/dates when they are in the ReQL raw format.