Seeking Feedback / Critiques

[neuman]

Thoughts?

@mephaust @ewdurbin @jtauber @xyzmes @kyen99 ?

[kyen99]

I wanted to try this with a real project before providing feedback but didn't get a chance to over the weekend and still wanted to send some thoughts back...

This is a really elegant solution to a normally pretty ugly problem. I like that you only provide the minimum necessary to validate and enumerate actions rather than trying to create something more comprehensive (and complex). This seems to be just enough.

The verb/noun terminology, while pretty accurate feels really abstract to me. I can imagine the first time I share code with someone I would have to explain that, "the verb/noun thing is for user permissions". Using something like AuthAction and AuthObject would seem to be a bit more self-explanatory, albeit while implying more limited use. I'm not sure I have a better suggestion.

The intro page example is concise. I had no trouble understanding how to use CB after a single, quick read.

I will definitely try to use this for a current project.

[neuman]

@kyen99 Thanks for taking a look! I think you could be right about the naming convention. I debated heavily whether to change it, and decided not to in order to not discourage users of the previous, simpler version from upgrading. Those names are actually pretty great suggestions.

Glad to hear that the intro got the job done, of the whole project that's actually the part I have the most anxiety about getting just right.

I can't wait to hear about your experiences using it! Good luck and feel free to ping me here or by email if you have any trouble.