xnmt icon indicating copy to clipboard operation
xnmt copied to clipboard

No test for loading the serialized model?

Open philip30 opened this issue 6 years ago • 1 comments

Is there currently a guarantee that the serialized parameters will be the same as when we save the model?

I think we should make a test like:

  1. x = initialize model
  2. do training for several steps
  3. path = save the model(x)
  4. y = load the model(path)
  5. assertEqual(x.param == y.param) ?

philip30 avatar Jul 09 '18 04:07 philip30

I think we're currently only testing that loading a model doesn't cause a crash, so adding a correctness test seems like a nice idea.

msperber avatar Jul 09 '18 12:07 msperber