ExplainaBoard icon indicating copy to clipboard operation
ExplainaBoard copied to clipboard

Published 20 hours ago • verified publisher icon neulab

Concrete data type

Open odashi opened this issue 2 years ago • 2 comments

FeatureTypes have the dtype member, which specifies the data type of corresponding data. However, this value is represented as str and it is unclear that what kind of values are valid for this member. Particularly, we need to:

  • Make a reference of valid dtype values. It should be either (1) defined by ourselves (in this repository), or (2) borrowed from other software.
  • Make a mechanism to restrict dtype member.

RFC: @neubig @pfliu-nlp

odashi avatar Sep 10 '22 00:09 odashi

Yeah, this definitely seems reasonable to me. An Enum seems reasonable to me, but any other option sounds fine too.

neubig avatar Sep 10 '22 01:09 neubig

Another problem is that JSON files involve different dtype definitions (one from ExplainaBoard, one from Datalab), which is a main source of confusion of my refactoring. We also need to consolidate them to just one type definition. I recommend not tot use Datalab's one and convert it to ExplainaBoard's data type once we loaded information from Datalab.

odashi avatar Sep 10 '22 04:09 odashi