react-svg-timeline icon indicating copy to clipboard operation
react-svg-timeline copied to clipboard

Unable to zoom in/out the timeline when there is at least one selected event

Open zhenghow93 opened this issue 1 year ago • 3 comments

Whenever there is at least one selected event, the <MouseCursor /> component is hidden, the logic is as shown in line 132 of the file /src/timeline/layers/interaction/Interaction.tsx, hence making zoom-in or zoom-out impossible via mouse click.

Is there a specific reason for this behaviour? I can resort to pinning the event instead of selecting the event if I still need the zoom to function while having the selected events highlighted, but styling options will be different (I can't assign fillColor pinned events).

zhenghow93 avatar Jan 16 '24 05:01 zhenghow93

I honestly don't remember why we changed it this way 🙈 Could it be that selecting events otherwise leads to unintentional zooming?

Feel free to just fork the repository and change the logic according to your needs.

netzwerg avatar Jan 19 '24 13:01 netzwerg

Thanks for the reply. We did fork it and made quite a number of functional and aesthetic customizations which are configurable via props. I'm asking for permission from my workplace whether it's fine to make a pull request to this repo. It'll be useful for the community

zhenghow93 avatar Jan 26 '24 00:01 zhenghow93

@zhenghow93 - were you able to get your fork available? I would like to see your customizations as well. Thanks!

shivika avatar Jun 20 '24 13:06 shivika