n98-magerun icon indicating copy to clipboard operation
n98-magerun copied to clipboard

installed APCU misinterpreted as APC

Open Flyingmana opened this issue 10 years ago • 5 comments

got an Bytecode Cache apc found. found on install, but I only have the stripped down APCU installed.

Dont know if it has any side effects from magerun side, but its in any case a false positive.

Flyingmana avatar Jun 21 '15 13:06 Flyingmana

Hi Daniel, are you referring to the sys:info command? -- Tom

tkn98 avatar Jun 22 '15 07:06 tkn98

oh, sorry to not mention it. Was part of the install command.

Flyingmana avatar Jun 22 '15 07:06 Flyingmana

Ok, I think it's "only" a false positive, can you take a look what causes the flaw?

tkn98 avatar Jun 22 '15 08:06 tkn98

I dont know how magerun tests for APC, but I would assume APCU has added a lot of old apc calls as mock, so it works for everey old code which used apc as a cache. So i expect the only sure way is to check for APCU and ignore a found APC when both exist.

Flyingmana avatar Jun 22 '15 08:06 Flyingmana

Okay, this needs review. I think it's useful to check for each of those as they are of value for performance related configurations as well to check for the new opcode cache in PHP core (if not already done). So just to differentiate the checks). The false positive have to go away. I dunno if I on my box I can quickly test this, I thought as you ran over this you perhaps can check more quickly. I think the code is rather simple of that check but have not reviewed it.

tkn98 avatar Jun 22 '15 09:06 tkn98