nx-guides icon indicating copy to clipboard operation
nx-guides copied to clipboard

Notebook on lowest common ancestor algorithm

Open dtekinoglu opened this issue 3 years ago • 2 comments
trafficstars

Hello,

I want to create an explanatory notebook on lowest common ancestor algorithm. If it is okay for you, I will start working on it.

dtekinoglu avatar Apr 12 '22 18:04 dtekinoglu

I think LCA would be a good candidate for a notebook; however, there are a few things to be aware of...

  • The implementation is quite complicated. This of course makes it a good candidate for a detailed explanation, but it also makes it a good candidate for review. Perhaps the best way to explain the LCA algorithm would be to see if we can't make the code itself more clear!
  • Similarly, there is at least one open issue on LCA which illustrates a corner-case that no one has yet been able to track down: networkx/networkx#4458 and the related examples in networkx/networkx#4844. It's a completely different project than creating the notebook, but tracking down and fixing this case would be a huge improvement to the LCA function. I just wanted to mention it since you're interested in LCA!

rossbar avatar Apr 15 '22 06:04 rossbar

Thank you @rossbar , I will be looking into it.

dtekinoglu avatar Apr 16 '22 14:04 dtekinoglu