nx-guides icon indicating copy to clipboard operation
nx-guides copied to clipboard

Add PageRank notebook

Open navyagarwal opened this issue 2 years ago • 3 comments

Here's the notebook for the PageRank algorithm.

I would love to get an initial review. (I am concerned that some portions might have become too complex)

(The function my_draw_networkx_edge_labels at the end of the notebook will be added to the main NetworkX repo.)

navyagarwal avatar Jun 22 '23 20:06 navyagarwal

@navyagarwal I have fixed up the notebooks (heading levels and linting) so they pass our CI. You would need to pull down the changes git pull origin pagerank to your local machine before pushing any new changes. Are you using Google Colab to make the notebooks or doing them locally? The linting needs to be setup before pushing with pre-commit :)

MridulS avatar Jul 10 '23 15:07 MridulS

@MridulS I am writing the notebooks locally, and I didn't know about the linting before, but I think I found the instructions now, this here is the one, right?

navyagarwal avatar Jul 10 '23 19:07 navyagarwal

Yeah those are the ones :) but it misses one step (a git add content/) after the conversion to ipynb. I would suggest looking at the CI workflow step for linting https://github.com/networkx/nx-guides/blob/main/.github/workflows/notebooks.yml

And as you can see it's not too intuitive to do this currently but we are stuck with this process for now 😅 but we really should do a better job of documenting everything here.

MridulS avatar Jul 10 '23 19:07 MridulS