ntc-templates icon indicating copy to clipboard operation
ntc-templates copied to clipboard

Published 20 hours ago • verified publisher icon networktocode

Fix XR7 parse error where ARP EVPN line exists

Open garymccann opened this issue 8 months ago • 3 comments

Fixes an IOS-XR version 7 issue, where a line is now included for ARP EVPN

garymccann avatar Mar 31 '25 19:03 garymccann

Hi @garymccann I made a couple of adjustments.

  • Regenerated structured data so the keys are in alphabetical order
  • Replaced literal spaces with regexes
  • Replaced a few singular whitespace regexes with a more flexible whitespace regex (one or more)

Thank you!

mjbear avatar Apr 01 '25 03:04 mjbear

hey @mjbear - can you please break these adjustments into their own PR - i do not like touching files unrelated to the feature, increasing the blast radius and while i don't see anything wrong with changing the order, it may confuse folk who are using the raw data, since it does not follow any alphabetical ordering. I will revert these PR changes.

garymccann avatar Apr 02 '25 15:04 garymccann

hey @mjbear - can you please break these adjustments into their own PR - i do not like touching files unrelated to the feature, increasing the blast radius and while i don't see anything wrong with changing the order, it may confuse folk who are using the raw data, since it does not follow any alphabetical ordering. I will revert these PR changes.

@garymccann Sure thing. ~I'll start canceling them if you haven't already.~ You got 'em. :slightly_smiling_face:

~There might be one or two items left for us to include on this PR, but we'll see as I take a gander now.~

mjbear avatar Apr 02 '25 22:04 mjbear