ntc-templates
ntc-templates copied to clipboard
Update fortinet_get_system_interface.textfsm to new version 6.4 Fortinet
Create the new match case to version 6.4 Fortinet.
@GustavoMaga Thanks for the PR, however, we will need the existing test case to pass, and we will also need either a new test case or an update to the existing test case to demonstrate correctly parsing with the 6.4 output.
@GustavoMaga As Jacob commented, the ntc-templates project requires all tests to pass for any change.
Additionally if support is added for output differences then raw CLI output has to be added as part of the pull request (PR). The test data allows the changes to be tested and confirmed against existing raw output as well as the new output via helper scripts.
I hope this helps. Please respond back if there are questions.
@GustavoMaga are you still interested in seeing this PR completed?
@pnpestov Might you also be willing to provide raw command output for this PR as well?
- fortinet_get_system_interface
Though you might not have access to 6.4 anymore and the template may not need changed for this command on 7.0. Thank you for any assistance you can provide here. :grinning:
Might you also be willing to provide raw command output for this PR as well?
- fortinet_get_system_interface
@mjbear Unfortunately, I do not have access to version 6.4, but for 7.0.15 I attach the received data. FortiGate-40F_get_system_interface.zip
Might you also be willing to provide raw command output for this PR as well?
- fortinet_get_system_interface
@mjbear Unfortunately, I do not have access to version 6.4, but for 7.0.15 I attach the received data. FortiGate-40F_get_system_interface.zip
It took a moment for GitHub to refresh the thread for me. :man_shrugging: Thank you! I'll work with that.
It took a moment for GitHub to refresh the thread for me. 🤷♂️ Thank you! I'll work with that.
Please, you are doing a very necessary and important thing.
closed by #1874