ntc-templates icon indicating copy to clipboard operation
ntc-templates copied to clipboard

Update fortinet_get_system_interface.textfsm to new version 6.4 Fortinet

Open GustavoMaga opened this issue 1 year ago • 3 comments

Create the new match case to version 6.4 Fortinet.

GustavoMaga avatar Jan 15 '24 23:01 GustavoMaga

@GustavoMaga Thanks for the PR, however, we will need the existing test case to pass, and we will also need either a new test case or an update to the existing test case to demonstrate correctly parsing with the 6.4 output.

jmcgill298 avatar Jul 22 '24 22:07 jmcgill298

@GustavoMaga As Jacob commented, the ntc-templates project requires all tests to pass for any change.

Additionally if support is added for output differences then raw CLI output has to be added as part of the pull request (PR). The test data allows the changes to be tested and confirmed against existing raw output as well as the new output via helper scripts.

I hope this helps. Please respond back if there are questions.

mjbear avatar Aug 04 '24 18:08 mjbear

@GustavoMaga are you still interested in seeing this PR completed?

jmcgill298 avatar Aug 15 '24 13:08 jmcgill298

@pnpestov Might you also be willing to provide raw command output for this PR as well?

  • fortinet_get_system_interface

Though you might not have access to 6.4 anymore and the template may not need changed for this command on 7.0. Thank you for any assistance you can provide here. :grinning:

mjbear avatar Oct 11 '24 10:10 mjbear

Might you also be willing to provide raw command output for this PR as well?

  • fortinet_get_system_interface

@mjbear Unfortunately, I do not have access to version 6.4, but for 7.0.15 I attach the received data. FortiGate-40F_get_system_interface.zip

pnpestov avatar Oct 11 '24 12:10 pnpestov

Might you also be willing to provide raw command output for this PR as well?

  • fortinet_get_system_interface

@mjbear Unfortunately, I do not have access to version 6.4, but for 7.0.15 I attach the received data. FortiGate-40F_get_system_interface.zip

It took a moment for GitHub to refresh the thread for me. :man_shrugging: Thank you! I'll work with that.

mjbear avatar Oct 11 '24 12:10 mjbear

It took a moment for GitHub to refresh the thread for me. 🤷‍♂️ Thank you! I'll work with that.

Please, you are doing a very necessary and important thing.

pnpestov avatar Oct 11 '24 12:10 pnpestov

closed by #1874

mjbear avatar Oct 12 '24 15:10 mjbear