ntc-templates icon indicating copy to clipboard operation
ntc-templates copied to clipboard

Add Edgecore platform with 7 templates

Open PavloSkliarenko opened this issue 2 years ago • 3 comments

Templates for Edgecore commands:

show interfaces brief show interfaces status show interfaces switchport show ip interface show system show version show vlan

PavloSkliarenko avatar Sep 01 '23 12:09 PavloSkliarenko

@itdependsnetworks @jmcgill298 @jvanderaa Should I make separate PR for each template when it's totally new device platform?

PavloSkliarenko avatar Sep 10 '23 19:09 PavloSkliarenko

Generally we are going for one PR per template update/inclusion for discussion sake. At this point that is water under the bridge and keep this in place.

jvanderaa avatar Sep 11 '23 00:09 jvanderaa

@jvanderaa Tests are failing because of tests/cisco_ios/show_ip_interface/cisco_ios_show_ip_interface7.yml. I've made PR, which fixed it

PavloSkliarenko avatar Nov 06 '23 19:11 PavloSkliarenko

Can this be merged?

AlexLardschneider avatar May 17 '24 08:05 AlexLardschneider

I'm keen for this to be merged but I gave it a test and found an issue: I have edgecores with SFP ports, which report the type as '10GBASE SFP+' - the templates don't work with this due to the space. Changing TYPE to (.*?) seems to fix it.

samk-acw avatar Jun 25 '24 07:06 samk-acw