circuit-maintenance-parser icon indicating copy to clipboard operation
circuit-maintenance-parser copied to clipboard

Update Windstream Parser for new emails

Open aliex-13 opened this issue 1 year ago • 1 comments

It seems Windstream have updated their emails with an additional table to include GPS location - Lat and Long.

This has messed with the existing parser so i've had to add some additional checks to the parser.

Just re-checks for maint_id, start and end time.

No other changes included.

aliex-13 avatar Aug 07 '24 03:08 aliex-13

Hey @glennmatthews, test email has been added and unit tests updated. Other threads have been resolved.

aliex-13 avatar Aug 13 '24 23:08 aliex-13

@aliex-13 could you fix the CI tests?

chadell avatar Aug 14 '24 07:08 chadell

Hey @chadell - I've pushed updates to fix the pylint issues but other issues unrelated to my code are occurring. Any chance you could take a look at the pipeline and let me know. I noticed these when running my own tests internally but didn't want to mess around with other code which was already in this state.

aliex-13 avatar Aug 14 '24 09:08 aliex-13

Hey @chadell - I've pushed updates to fix the pylint issues but other issues unrelated to my code are occurring. Any chance you could take a look at the pipeline and let me know. I noticed these when running my own tests internally but didn't want to mess around with other code which was already in this state.

Yes @aliex-13 , going to fix the doctest

chadell avatar Aug 19 '24 06:08 chadell