circuit-maintenance-parser icon indicating copy to clipboard operation
circuit-maintenance-parser copied to clipboard

Documentation on Contributing - Needs Updating

Open jvanderaa opened this issue 2 years ago • 5 comments

Environment

  • Python version: 3.x
  • circuit_maintenance_parser version: latest

Expected Behavior

I expected that the invoke tasks would allow for the testing

Observed Behavior

  • Errors due to no Dockerfile

Steps to Reproduce

  1. clone repo
  2. run invoke build
  3. Get error that Dockerfile was not present

jvanderaa avatar Feb 07 '23 01:02 jvanderaa

True, the library runs simple pytest testing without a container.

chadell avatar Feb 10 '23 14:02 chadell

@jvanderaa

I made a quick update with this PR: https://github.com/networktocode/circuit-maintenance-parser/pull/212

Does it look alright to you?

csessh avatar Feb 23 '23 07:02 csessh

On macOS using Poetry to install will fail. I haven't debugged further, but building numpy fails, though I'm not sure what it is that Poetry is trying to install as it doesn't include a number of required packages like pytest.

Installing packages with pip in a virtualenv work fine:

pip install pydantic chardet geopy tzwhere backoff icalendar netconan invoke toml click lxml pytest
pytest --log-cli-level=DEBUG --capture=tee-sys -k test_parsers

slyngshede avatar May 02 '23 11:05 slyngshede

hi @slyngshede , which Poetry version are you using?

chadell avatar May 03 '23 04:05 chadell

@chadell You can ignore my comment, it was related to running Python 3.11 and newer versions of NumPy.

slyngshede avatar May 26 '23 13:05 slyngshede