sdk icon indicating copy to clipboard operation
sdk copied to clipboard

TestRefreshClient_Sandbox is unstable

Open Bolodya1997 opened this issue 3 years ago • 3 comments

https://github.com/networkservicemesh/sdk/runs/2359443948?check_suite_focus=true#step:5:158

time="2021-04-16T05:46:42Z" level=warning msg="count 1 < atLeast 2"
...
time="2021-04-16T05:46:43Z" level=warning msg="count 1 < atLeast 2"
time="2021-04-16T05:46:43Z" level=warning msg="count 2 < atLeast 3"
...
time="2021-04-16T05:46:43Z" level=warning msg="count 2 < atLeast 3"
time="2021-04-16T05:46:43Z" level=warning msg="count 1 < atLeast 2"
...
time="2021-04-16T05:46:43Z" level=warning msg="count 1 < atLeast 2"
time="2021-04-16T05:46:43Z" level=warning msg="count 3 < atLeast 4"
...
time="2021-04-16T05:46:43Z" level=warning msg="count 3 < atLeast 4"
time="2021-04-16T05:46:43Z" level=warning msg="count 4 < atLeast 8"
...
time="2021-04-16T05:46:43Z" level=warning msg="count 4 < atLeast 8"
time="2021-04-16T05:46:43Z" level=warning msg="count 5 < atLeast 8"
...
time="2021-04-16T05:46:43Z" level=warning msg="count 5 < atLeast 8"
time="2021-04-16T05:46:43Z" level=warning msg="count 6 < atLeast 8"
...
time="2021-04-16T05:46:43Z" level=warning msg="count 6 < atLeast 8"
time="2021-04-16T05:46:44Z" level=warning msg="count 7 < atLeast 8"
No logger in context
...
No logger in context
--- FAIL: TestRefreshClient_Sandbox (1.34s)
    client_utils_test.go:228: 
        	Error Trace:	client_utils_test.go:228
        	            				server.go:79
        	            				server.go:82
        	            				server.go:84
        	            				server.go:103
        	            				server.go:84
        	            				server.go:58
        	            				server.go:79
        	            				server.go:82
        	            				server.go:82
        	            				server.go:103
        	            				server.go:84
        	            				server.go:106
        	            				server.go:79
        	            				server.go:82
        	            				server.go:82
        	            				server.go:103
        	            				server.go:84
        	            				server.go:54
        	            				server.go:79
        	            				server.go:82
        	            				server.go:82
        	            				server.go:103
        	            				server.go:84
        	            				server.go:130
        	            				server.go:79
        	            				server.go:82
        	            				server.go:82
        	            				server.go:103
        	            				server.go:84
        	            				server.go:52
        	            				multi_executor.go:54
        	            				serialize.go:68
        	            				asm_amd64.s:1371
        	Error:      	Not equal: 
        	            	expected: 4
        	            	actual  : 1
        	Test:       	TestRefreshClient_Sandbox
        	Messages:   	Unexpected state
    client_test.go:229: 
        	Error Trace:	client_test.go:229
        	Error:      	Condition never satisfied
        	Test:       	TestRefreshClient_Sandbox
FAIL

Bolodya1997 avatar Apr 16 '21 05:04 Bolodya1997

@d-uzlov If you will run out of tasks then be free to check if this issue is actual :) We got clock injection into netwrokservices and I hope it solved this problem, but we need to verify it.

denis-tingaikin avatar May 05 '21 11:05 denis-tingaikin

looks like the clock is not ready for sandbox. So this actually is blocked.

denis-tingaikin avatar May 05 '21 11:05 denis-tingaikin

Seems like this should just work now.

Need to check this by enabling this test https://github.com/networkservicemesh/sdk/blob/8e964705e60431463c60b6de44d591f5ea605035/pkg/networkservice/common/refresh/client_test.go

denis-tingaikin avatar Dec 04 '22 23:12 denis-tingaikin