sdk icon indicating copy to clipboard operation
sdk copied to clipboard

timeout: take the minimum expiration time of pathSegments

Open glazychev-art opened this issue 1 year ago • 1 comments

Description

The previous implementation took into account only the previous segment. This is mistake. For example: NSC (1min) ---> NSMgr (5min) ---> Fwd (5min) --->... If NSC and NSMgr die, then the Fwd timeout will work only after 5 minutes. But authorize policies look at the whole path, so an error will occur when closing (the client token has already expired).

Issue link

https://github.com/networkservicemesh/deployments-k8s/issues/8882

How Has This Been Tested?

  • [x] Added unit testing to cover
  • [x] Tested manually
  • [ ] Tested by integration testing
  • [ ] Have not tested

Types of changes

  • [x] Bug fix
  • [ ] New functionality
  • [ ] Documentation
  • [ ] Refactoring
  • [ ] CI

glazychev-art avatar Mar 23 '23 07:03 glazychev-art

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2502d93). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1439   +/-   ##
=======================================
  Coverage        ?   70.28%           
=======================================
  Files           ?      242           
  Lines           ?    11006           
  Branches        ?        0           
=======================================
  Hits            ?     7736           
  Misses          ?     2770           
  Partials        ?      500           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Mar 23 '23 07:03 codecov[bot]