sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Nsmgr, nsmgr-proxy and proxy-dns don't use default registry client

Open NikitaSkrynnik opened this issue 2 years ago • 0 comments

Question

Why don't registry-memory, nsmgr, nsmgr-proxy and proxy-dns use default registry client ?

Examples

Places where registry client should be used:

  1. https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/chains/nsmgr/server.go#L202
  2. https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/chains/nsmgr/server.go#L222
  3. https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/chains/nsmgrproxy/server.go#L201
  4. https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/chains/nsmgrproxy/server.go#L212
  5. https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/chains/nsmgrproxy/server.go#L247
  6. https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/chains/nsmgrproxy/server.go#L271
  7. https://github.com/networkservicemesh/sdk/blob/main/pkg/registry/chains/memory/server.go#L127
  8. https://github.com/networkservicemesh/sdk/blob/main/pkg/registry/chains/memory/server.go#L158
  9. https://github.com/networkservicemesh/sdk/blob/main/pkg/registry/chains/proxydns/server.go#L40
  10. https://github.com/networkservicemesh/sdk/blob/main/pkg/registry/chains/proxydns/server.go#L52

NikitaSkrynnik avatar Oct 27 '22 10:10 NikitaSkrynnik