sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Fix backward compatibility for NewNetworkServiceEndpointRegistryClient and NewNetworkServiceRegistryClient

Open edwarnicke opened this issue 2 years ago • 1 comments

NewNetworkServiceEndpointRegistryClient and NewNetworkServiceRegistryClient where recently enhanced. In that process, the leading "connectTo *url.URL" parameter was removed. The functionality continues to be supported via the WithClientURL option.

In order to avoid breaking current downstream users, the leading "connectTo *url.URL" has been restored in such a way that it has no effect if it is nil and otherwise utilize the WithClient option (to insure the code path is exercised).

edwarnicke avatar May 15 '22 17:05 edwarnicke

@denis-tingaikin Totally fine to discuss on the community call :) My concern is wrt folks who have their own NSEs and NSCs and the change this would mean for them.

edwarnicke avatar May 15 '22 19:05 edwarnicke