json-schema-validator
json-schema-validator copied to clipboard
networknt
Feat/multi-version-tests
This pull request is all about improving the existing unit tests. The current unit tests are mainly using the draft 4 version, but we should be making sure that these unit tests are ran for all of the compatible draft versions. By doing this we can guarantee backwards compatibility between draft versions.
I'm not ready yet, but I thought I'd open up a draft pull request so you guys know that I didn't forget about this feature.
I'm almost finished with the tests, but my development environment is throwing some strange jacoco error. However, my IDE can run the tests without a problem. This makes it difficult to catch the bugs I'm introducing. I'll get through this.
I may have uncovered a bug that only exists when the later draft versions are used. There's a couple of tests in the MaximumValidatorTest and MinimumValidatorTest classes that only fail when draft versions after v4 are used. I need to investigate some more, but this is a really good find potentially.
@jawaff Thank you for a PR to improve the tests.
Could you update your work? @stevehu Is there a chance to split the work and add a few smaller PRs rather than a huge one?
@jawaff @eirnym I am open to any option that can speed up the progress. My understanding is that this is not completed yet. @jawaff, please correct me if I am off track. Thanks.
We are using JSON Schema Test Suite to ensure compliance with the various specifications and most of the requested functionality is now present. Since this request is so old and has so many conflicts, it seems best to just close it.
