networkit icon indicating copy to clipboard operation
networkit copied to clipboard

Suppress `ReducedFunctionalityWarning`

Open Thijss opened this issue 2 years ago • 1 comments

Hi there,

Would it be possible to suppress the ReducedFunctionalityWarning? https://github.com/networkit/networkit/blob/2aaa0eecc82560c0d6b212e494706a23497dc8ea/networkit/simulation.pyx#L11-L14

If I understand correctly, I think it is only relevant when using EpidemicSimulationSEIR.getData() https://github.com/networkit/networkit/blob/2aaa0eecc82560c0d6b212e494706a23497dc8ea/networkit/simulation.pyx#L65

The warning is now raised on import.

Perhaps the same logic can be applied as applied here? https://github.com/networkit/networkit/blob/6205384e771c7e3ba1a1e2f46731b5ea01e1f80f/networkit/plot.py#L12-L17

The warning could then be logged upon running .getData() if not have_pandas

or an error could be thrown like the plot module: https://github.com/networkit/networkit/blob/6205384e771c7e3ba1a1e2f46731b5ea01e1f80f/networkit/plot.py#L123-L124

I am not too familiair with .pyx files, so not sure this is possible

Thijss avatar May 05 '22 15:05 Thijss

This seems quite simple to do; we could use an internal variable that suppresses the warning.

angriman avatar May 06 '22 08:05 angriman