gobbledegook icon indicating copy to clipboard operation
gobbledegook copied to clipboard

Add Class of Device debugging info

Open brett-lynnes opened this issue 6 years ago • 2 comments
trafficstars

This puts a bunch of spam in HciAdapter.h (i may separate out the debug/display functions at a later date), but it does appear to parse the 24bit Class of Device correctly so you can see what your device is announcing itself as. As far as I can tell, the only ones out there who actually use this information are Apple devices. Other devices may use the CoD to figure out which icon to display your server as.

brett-lynnes avatar Sep 03 '19 22:09 brett-lynnes

Hi Brett, this all looks good, though I would suggest a formatting treatment to match the existing ggk codebase (mostly curly brace placement and switch/case indentation.)

nettlep avatar Nov 21 '19 12:11 nettlep

ah yes, sorry about the formatting (our codebases don't match well at all, and i auto-formatted portions of GGK accidentally a long time ago). i will submit another request later with better formatting when i get the security stuff working (Agent1 dbus hookups from app-land are working pretty well with your server, but there were some modifications i had to make to mgmt). next update should have mgmt flushed out a lot more and a better encapsulation of security modes (holy crap BlueZ is a steaming pile of garbage on this).

On Thu, Nov 21, 2019 at 4:44 AM Paul Nettle [email protected] wrote:

Hi Brett, this all looks good, though I would suggest a formatting treatment to match the existing ggk codebase (mostly curly brace placement and switch/case indentation.)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nettlep/gobbledegook/pull/30?email_source=notifications&email_token=AITJ6K7HTNYV7TH5EN4A52LQUZ7CFA5CNFSM4ITLM24KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE2DCII#issuecomment-557068577, or unsubscribe https://github.com/notifications/unsubscribe-auth/AITJ6KYZZ473MX2OWWNRS5TQUZ7CFANCNFSM4ITLM24A .

brett-lynnes avatar Nov 21 '19 22:11 brett-lynnes