[citrix-ingress-controller] feat(extraVolumes): Addition

[eyenx]

• Adds extraVolume/Mounts to the Chart
• this allows us to deploy cic with additional volumemounts to implemente CSI Secret Provider Classes for holding the nslogin secret.

Signed-off-by: Toni Tauro [email protected]

[subashd]

hi @eyenx, Thanks for your enhancement, we will review and validate. And also we need to take care of other files as well, we will consider this as an enhancement.

[eyenx]

any update?

[eyenx]

bump

[raviganapatp]

hi @eyenx , with the extraVolumeMounts, this will only create extra mounts inside CIC, but you will still need to create the secret as CIC looks for environment variables NS_USER and NS_PASSWORD which picks the values from secret.

        - name: "NS_USER"
          valueFrom:
            secretKeyRef:
              name: {{ .Values.adcCredentialSecret }}
              key: username
        - name: "NS_PASSWORD"
          valueFrom:
            secretKeyRef:
              name: {{ .Values.adcCredentialSecret }}
              key: password

[eyenx]

I am aware of that

[raviganapatp]

hi @eyenx we have added this feature to have extra volume mounts and the same can be found in values.yaml

extraVolumeMounts: []
  # We usually recommend not to specify default resources and to leave this as a conscious
  # choice for the user.
  #- name: github-key
  #  mountPath: /etc/config/keys/
  #  readOnly: true
  #- name: agent-init-scripts
  #  mountPath: /docker-entrypoint.d/

extraVolumes: []
  # We usually recommend not to specify default resources and to leave this as a conscious
  # choice for the user.
  #- name: agent-init-scripts
  #  configMap:
  #     name: agent-init-scripts
  #     defaultMode: 0755
  #- name: github-key
  #  secret:
  #    secretName: github-key
  #    defaultMode: 0744