t3x-rte_ckeditor_image icon indicating copy to clipboard operation
t3x-rte_ckeditor_image copied to clipboard

Published 20 hours ago • verified publisher icon netresearch

Revert the change "fix package name for cms_rte_ckeditor in ext_emconf.php"

Open magicsunday opened this issue 1 year ago • 3 comments

The extension name is "rte_ckeditor" not "cms_rte_ckeditor" => https://github.com/TYPO3-CMS/rte_ckeditor/blob/main/composer.json

Fixes commit: #271 5cff197

magicsunday avatar Apr 11 '24 05:04 magicsunday

@magicsunday can you please describe what problem is solved by this commit?

Did you check the pipeline? It is broken now with this commit.

CybotTM avatar Apr 18 '24 09:04 CybotTM

In the failing tests / github "jobs" for v13 is still typo3/cms-recordlist mentioned, that was already removed in v12.

DavidBruchmann avatar Apr 18 '24 10:04 DavidBruchmann

@DavidBruchmann, thanks, created a new issues for this.

CybotTM avatar Apr 18 '24 10:04 CybotTM

@CybotTM , I am a little confused can we close this MR ?

Gitsko avatar May 22 '24 11:05 Gitsko

@Gitsko

@CybotTM , I am a little confused can we close this MR ?

I don't know, this MR does not describe what real world problem it fixes and it breaks the build. The MR should be declined or the fixed problem should be documented and the build should be fixed before accepting this MR.

CybotTM avatar May 23 '24 07:05 CybotTM

I agree, I would close the PR. @magicsunday you may be able to get a new MR if a problem occurs again.

Gitsko avatar May 23 '24 07:05 Gitsko

The extension name is "rte_ckeditor" not "cms_rte_ckeditor" => https://github.com/TYPO3-CMS/rte_ckeditor/blob/main/composer.json

Please revert commit 5cff197

This change makes it impossible to activate the extension in TYPO3 v12 (non-Composer mode).

dittebrandt avatar Jun 06 '24 12:06 dittebrandt