protobuf2flowtype icon indicating copy to clipboard operation
protobuf2flowtype copied to clipboard

make dependencies work?

Open raould opened this issue 7 years ago • 1 comments

hi, can the package.json say exactly what version of protobufjs it uses? I've been going around in circles trying to debug why things aren't working and I am guessing maybe it boils down to version mismatches between protobufjs and protobuf2flowtype.

I have protobuf2flowtype 3.0.4 and protobufjs 6.7.3. When I generate the flow typings, I see

const builder = exports.builder = new ProtoBuf.Builder();

but there's no Builder() in the protobuffjs I have afaict. Then when I look at the example in the README for protobuf2flowtype, I see

const builder = exports.builder = ProtoBuf.loadJson(jsonDescriptor);

but there's also no loadJson() in the protobufjs I have.

etc.

raould avatar May 12 '17 20:05 raould

Hi @raould

The package json does state which version of protobufjs it uses 5

https://github.com/netproteus/protobuf2flowtype/blob/master/package.json#L27

I had been waiting to support version 6 untillGRPC sorted their support out but this has gone on too long and I think support for 6 is now past due

netproteus avatar May 14 '17 08:05 netproteus