laravel-bootstrap-4-forms icon indicating copy to clipboard operation
laravel-bootstrap-4-forms copied to clipboard

Setting button ID via chainable method is ignored

Open gavinsbtm opened this issue 3 years ago • 0 comments

Adding an ID to a button element using chainable id method is ignored.

Eg: Form::button('Upload')->id('upload-btn')

Output is: <button type="button" class="btn btn-primary">Upload</button>

Expected output: <button id="upload-btn" type="button" class="btn btn-primary">Upload</button>

Changing renderButton() function in FormBuilder.php fixes this:

private function renderButton(): string
    {
        extract($this->get('id', 'type', 'value', 'disabled'));
        $class = $this->getBtnAnchorClasses();
        $attrs = $this->buildHtmlAttrs(['id' => $id, 'type' => $type, 'class' => $class, 'disabled' => $disabled]);
        return '<button ' . $attrs . '>' . $value . '</button>';
    }

gavinsbtm avatar Nov 10 '21 15:11 gavinsbtm