neuromaps icon indicating copy to clipboard operation
neuromaps copied to clipboard

Bug in all parcellation-specific null models

Open rmarkello opened this issue 3 years ago • 1 comments

The following line is present in all parcellation-specific null models (i.e., nulls.vasa, nulls.hungarian, nulls.baum, and nulls.cornblath):

https://github.com/netneurolab/brainnotation/blob/09ef3c88270f85d97de83d69e51cb6917e21f417/brainnotation/nulls/nulls.py#L190

But it should be the opposite (i.e., if parcellation is None). Currently all of these functions are useless :grimacing: Should be an easy fix, though!

(h/t to @danjgale for pointing this out)

rmarkello avatar Jul 20 '21 18:07 rmarkello