netlify-plugin-gatsby icon indicating copy to clipboard operation
netlify-plugin-gatsby copied to clipboard

Test plugin with old versions of Gatsby

Open ascorbic opened this issue 2 years ago • 6 comments

Currently the latest version of the plugin requires Gatsby 4, but there's nothing specific that demands this. We should test this with Gatsby 3 and Gatsby 2 to ensure that a) it works with Gatsby Functions in Gatsby 3, and b) that in older versions it doesn't generate any functions. If this is confirmed, we should update plugins.json to reflect that

ascorbic avatar May 11 '22 14:05 ascorbic

Is this something we still want to look at @ascorbic and if so, would it be reasonable to look at just v3, or should we still consider v2?

nickytonline avatar Jun 27 '22 19:06 nickytonline

It's lower priority, but I think it would be worth checking. It's a relatively simple one, because it doesn't support any form of SSR/DSG or functions, so it would just be checking that a) it doesn't break and b) that it saves and restores the cache

ascorbic avatar Jun 28 '22 08:06 ascorbic

@seldo - Do we have any data on which version of Gatsby people are using?

MarcL avatar Sep 23 '22 15:09 MarcL

Sure do! https://app.mode.com/netlify/reports/00342b250700/runs/bfbe51689650

TLDR: in the last 30 days about 13k accounts built with Gatsby. Of those about half are on version 4; the next most popular version is 2, which about 25% of builds used. More details if you click through to Mode.

seldo avatar Sep 28 '22 15:09 seldo

Awesome, this is really useful. For reference, version 2 of Gatsby is no longer officially supported by Gatsby themselves https://www.gatsbyjs.com/docs/reference/release-notes/gatsby-version-support/

orinokai avatar Sep 29 '22 08:09 orinokai

From this data supporting v3 is a no-brainer. Anybody still using v2 is probably not paying enough attention to care about whether we support them or not.

seldo avatar Sep 29 '22 14:09 seldo

Was able to get this Gatsby v3 app to work locally using netlify dev, and functions are working as expected. @ascorbic if everything looks good on your end as well I can make the update for the plugins.json

taty2010 avatar Jan 18 '23 21:01 taty2010

Great! Could you also try it with netlify serve?

ascorbic avatar Jan 19 '23 13:01 ascorbic

Everything is working when running ntl serve

taty2010 avatar Jan 19 '23 20:01 taty2010

Great! I'd say let's go ahead an update the package.json and plugins.json

ascorbic avatar Jan 20 '23 09:01 ascorbic

Updated plugin PR https://github.com/netlify/plugins/pull/1104

taty2010 avatar Jan 23 '23 17:01 taty2010