cli icon indicating copy to clipboard operation
cli copied to clipboard

fix: refactor image handling to use `@netlify/images`

Open keanu-a opened this issue 4 months ago โ€ข 5 comments

๐ŸŽ‰ Thanks for submitting a pull request! ๐ŸŽ‰

Summary

Refactors logic of the initializeImageProxy function to use @netlify/images instead of express function. Removed unit tests for the old logic as well.

Fixes #EX-536


For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [ ] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests.
  • [ ] Update or add tests (if any source code was changed or added) ๐Ÿงช
  • [ ] Update or add documentation (if features were changed or added) ๐Ÿ“
  • [ ] Make sure the status checks below are successful โœ…

A picture of a cute animal (not mandatory, but encouraged)

keanu-a avatar Aug 26 '25 20:08 keanu-a

๐Ÿ“Š Benchmark results

Comparing with 3539b0dc68802af88a032fb3925af24174c82a09

  • Dependency count: 1,074 โฌ†๏ธ 0.09% increase vs. 3539b0dc68802af88a032fb3925af24174c82a09
  • Package size: 298 MB โฌ†๏ธ 0.01% increase vs. 3539b0dc68802af88a032fb3925af24174c82a09
  • Number of ts-expect-error directives: 381 (no change)

github-actions[bot] avatar Aug 26 '25 20:08 github-actions[bot]

@copilot fix the merge conflicts and address the comment. also please let me know the extent of coverage we have in place for the image behaviour.

serhalp avatar Nov 27 '25 18:11 serhalp

@serhalp I've opened a new pull request, #7802, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Nov 27 '25 18:11 Copilot

@copilot merge main into the branch and resolve the conflicts

serhalp avatar Nov 27 '25 19:11 serhalp

@serhalp I've opened a new pull request, #7803, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Nov 27 '25 19:11 Copilot