cli
cli copied to clipboard
refactor: replace got with node-fetch on dev-miscellaneous.test.js
Summary
refactor: replace got with node-fetch on dev-miscellaneous.test.js
related to #5695
For us to review and ship your PR efficiently, please perform the following steps:
- [x] Open a bug/issue before writing your code ๐งโ๐ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐ฅ (e.g. incident related), you can skip this step.
- [x] Read the contribution guidelines ๐. This ensures your code follows our style guide and passes our tests.
- [x] Update or add tests (if any source code was changed or added) ๐งช
- [x] Update or add documentation (if features were changed or added) ๐
- [x] Make sure the status checks below are successful โ
A picture of a cute animal (not mandatory, but encouraged)
๐ Benchmark results
Comparing with 51f1cf6af905dda3b0fbb0a1d940b97a2a9ee076
- Dependency count: 1,359 (no change)
- Package size: 313 MB (no change)
- Number of ts-expect-error directives: 980 (no change)
๐ Benchmark results
Comparing with 3268f29d9e94b52cf07819b3a83b7886d8330c1e
- Dependency count: 1,398 (no change)
- Package size: 404 MB (no change)
- Number of ts-expect-error directives: 0 (no change)
For a while there looked to be several unrelated errors preventing this from getting merged, but most of those flaky tests look to have been resolved in main
so I took a stab at merging the latest into this branch. Unfortunately though, the most recent run does look to have a genuine failure related to the code this function is testing, though it very well might be specific to windows + node 20.
FAIL tests/integration/commands/dev/dev-miscellaneous.test.js > commands/dev-miscellaneous > should detect content changes in edge functions
AssertionError: expected 'There was an error with an Edge Functโฆ' to deeply equal 'Hello builder'
- Expected
+ Received
- Hello builder
+ There was an error with an Edge Function. Please check the terminal for more details.
When I have some time again, I will try to spin this up on a local windows instance to see if I can uncover why the edge function might be returning an error in this case.