cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: automatic create tsconfig for editor support on functions

Open lukasholzer opened this issue 1 year ago โ€ข 4 comments

Fixes https://github.com/netlify/pod-dev-foundations/issues/595

๐ŸŽ‰ Thanks for submitting a pull request! ๐ŸŽ‰

Summary

Fixes the editor support for the new functions V2 API. By that we enforce that the editor is in sync with the build values


For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [ ] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests.
  • [ ] Update or add tests (if any source code was changed or added) ๐Ÿงช
  • [ ] Update or add documentation (if features were changed or added) ๐Ÿ“
  • [ ] Make sure the status checks below are successful โœ…

A picture of a cute animal (not mandatory, but encouraged)

lukasholzer avatar Oct 05 '23 14:10 lukasholzer

๐Ÿ“Š Benchmark results

Comparing with 2a688760c93fd64b60fe7db41b033aa73c6aab8d

  • Dependency count: 1,369 (no change)
  • Package size: 379 MB โฌ‡๏ธ 0.00% decrease vs. 2a688760c93fd64b60fe7db41b033aa73c6aab8d

github-actions[bot] avatar Oct 05 '23 14:10 github-actions[bot]

With that configuration, I get even in JavaScript completion for the Netlify.env

CleanShot 2023-10-06 at 10 07 20

lukasholzer avatar Oct 06 '23 08:10 lukasholzer

@lukasholzer is this PR still relevant, or should we close/draft?

sarahetter avatar Apr 23 '24 16:04 sarahetter

@sarahetter yes but sadly never had time to finish it up

lukasholzer avatar Apr 25 '24 12:04 lukasholzer