cli icon indicating copy to clipboard operation
cli copied to clipboard

Published 20 hours ago • verified publisher icon netlify

chore: enable the use eszip feature flag for edge functions

Open EwanValentine opened this issue 2 years ago • 2 comments

🎉 Thanks for submitting a pull request! 🎉

Summary

Updates the CLI to utilise the eszip changes for edge functions.

For us to review and ship your PR efficiently, please perform the following steps:

  • [internal] Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • [x] Read the contribution guidelines 📖. This ensures your code follows our style guide and passes our tests.
  • [n\a] Update or add tests (if any source code was changed or added) 🧪
  • [n\a] Update or add documentation (if features were changed or added) 📝
  • [ ] Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

EwanValentine avatar Jul 11 '22 15:07 EwanValentine

Are we sure to enable this for all cli users? On LD I see it is only on for 5 users.

danez avatar Jul 12 '22 08:07 danez

@danez oh, strange. This has been changed whilst I was away. I'll double-check what's happened here, it was fully on before. Good spot.

EwanValentine avatar Jul 12 '22 09:07 EwanValentine

📊 Benchmark results

Comparing with c0b9722dcbe1b6795de1e6baa16e140b28b66b88

Package size: 222 MB

(no change)

^  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend
  • T-30 (8e5008023452309a617685fb5f71ebb4357338cf): 222 MB
  • T-29 (886eebc586441f60fc81dd65d571db9ac7993421): 222 MB
  • T-28 (f1d1d91248ae5792d246d15cc08a845ea5c8f9c4): 222 MB
  • T-27 (56cfac8d971cc1b1f0c1c1cdb310419e465d4f3d): 222 MB
  • T-26 (3af976e39fce40154f12ab5066befb0a22e5a149): 222 MB
  • T-25 (7a2af72e204fb8caf1c8f07de24a95c09b1781eb): 222 MB
  • T-24 (6fad2a86f8a1f13e2de866c65123b713ceb7b293): 222 MB
  • T-23 (1450e1e7fe4b2c581bc7c0dfd707cc6bf1a5749c): 222 MB
  • T-22 (8b8d8b3dd1f25404361fb58f09d6ff93a3e34e30): 222 MB
  • T-21 (dfe036520cc183b507cacb7098ccc70217d2a05d): 222 MB
  • T-20 (7d792df4bf41fd216b9f9652fe229b61c5df8e79): 222 MB
  • T-19 (ba96774c7e11ae5c33b816e14598d9854d64c378): 222 MB
  • T-18 (48d581aa7cfa898f3b100be83e1ecf3fece10711): 222 MB
  • T-17 (c0a4caded5fb55d15119045629ff9189f9777545): 222 MB
  • T-16 (ac4e0e498c01fa6a7fbd2db9c96a600cbe891cfd): 222 MB
  • T-15 (3073dbbaa9d2fe3ff06e3b74fd46186e291e1344): 222 MB
  • T-14 (2f9072b62c67523f44203322c0a655f96fac30ec): 222 MB
  • T-13 (091387f1a451910466a8ad360aded0fc5fffe25d): 222 MB
  • T-12 (a5bfa1178252a895000058f34c8e3279a5937e5e): 222 MB
  • T-11 (cfeea775d3067489b3f1cfaba9fe6e45b34ca744): 222 MB
  • T-10 (534293840195db2a519f324ede9528ba7320c34a): 222 MB
  • T-9 (e0f16807cb19dd7d52d934b8bf990c7414f35634): 222 MB
  • T-8 (2d4b68c478de776169c0ef7d08ed4804ad766d35): 222 MB
  • T-7 (cef0f455849531b14bac95f96664c2e2b95bd9b6): 222 MB
  • T-6 (54b12c860da2869e1c9a7f871d5ad367443a96c8): 222 MB
  • T-5 (2a41796ff9a805b386d7db69f32dc6064c565e3d): 222 MB
  • T-4 (59b81622e4772d66a02d074497e2ea41bba92740): 222 MB
  • T-3 (9385ddee0723ba8fcbe9c6992b54bc23eb21f6c9): 222 MB
  • T-2 (45d7100ad5953731f803d0097b47c34ddcef1ffc): 222 MB
  • T-1 (c0b9722dcbe1b6795de1e6baa16e140b28b66b88): 222 MB
  • T (current commit): 222 MB

github-actions[bot] avatar Aug 22 '22 08:08 github-actions[bot]