cli icon indicating copy to clipboard operation
cli copied to clipboard

Published 20 hours ago • verified publisher icon netlify

feat: graph:library production with persisted queries

Open sgrove opened this issue 2 years ago • 3 comments

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes:

  • netlify/labs#36
  • netlify/labs#35
  • Generated library code didn't specify a schemaId

Features:

  • Adds a production mode for graph:library that persists queries with various levels of caching and schemaId pinning
  • Adds a graph:init that creates an env var for webhook secret signing and a token for creating persisted queries and modifying schemas
  • Normalizes GraphQL operations document on graph:library to help minimize merge conflicts so multi-user teams have a better experience

For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Update or add tests (if any source code was changed or added) 🧪
  • [ ] Update or add documentation (if features were changed or added) 📝
  • [ ] Make sure the status checks below are successful ✅

sgrove avatar Mar 02 '22 04:03 sgrove

📊 Benchmark results

Comparing with 7c5f0e41c7ef61507633bd976fb1d0ba6cf04acf

Package size: 274 MB

⬇️ 0.00% decrease vs. 7c5f0e41c7ef61507633bd976fb1d0ba6cf04acf

^  380 MB  380 MB  380 MB  380 MB  380 MB  380 MB  380 MB  380 MB  380 MB  380 MB  380 MB  380 MB         
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐          
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |          
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |          
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |          
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |          
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |   274 MB 
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend
  • T-30 (7c5f0e41c7ef61507633bd976fb1d0ba6cf04acf): 274 MB
  • T-29 (f51066ecd170e86259ba7b9401c7fef7344793c0): 274 MB
  • T-28 (6695113c1505cca4bdaac48b1aafb89e250bc59b): 273 MB
  • T-27 (79cab6c927b512601e6ae561f1082e2c6a8895d2): 273 MB
  • T-26 (f35b14cc6562628137ed718e8518b5ff4bfa75ae): 273 MB
  • T-25 (2c58896b63650eadfdea60fac6b2b408952d9b3a): 273 MB
  • T-24 (89452281c9cfb1aff19991a93ed2638d0bc03734): 273 MB
  • T-23 (99985508bed75d2ec76f5f7eeed191b0e946d224): 273 MB
  • T-22 (d9bb192e680a11334f6aa04091ec3502bea28972): 273 MB
  • T-21 (129216e901a92ca6833e186930036f4351d2aee0): 273 MB
  • T-20 (59c3670268cb35a81eba33dd305ee4b2a2769b84): 273 MB
  • T-19 (fbd45102ad2222562751db2178a98f63f195fdef): 380 MB
  • T-18 (47181a47905aa9fe6533875a6a769c2db2dfae07): 380 MB
  • T-17 (d8bc64e6f77f84dad32fbc52f0a762d079e392c1): 380 MB
  • T-16 (02c8c8ade49092ce251a6f51ff64b395a3b9f000): 380 MB
  • T-15 (15d351e8b40478212d0fc8b96ab1b36a83589b7b): 380 MB
  • T-14 (647ad4d8e57b5dd7696379585a574c8c09743fa6): 380 MB
  • T-13 (c285dbcce008dd160e8978917fdd380ca059e4ff): 380 MB
  • T-12 (4ad0b4502e0002a3b6e5438efa668cfc834c4573): 380 MB
  • T-11 (a668861aee1ccc1a88b8674c45c10b887727cebb): 380 MB
  • T-10 (1cb5a917abc0699a6c7f65bac34905647d34ac6a): 380 MB
  • T-9 (15f34db7fa95b26fc415eb7edf41c54e099ab09d): 380 MB
  • T-8 (37251133813607fe06557756c00f8ba4574c292e): 380 MB
  • T-7 (62e64c471be5fc1068f719139559568a02db64f5): 380 MB
  • T-6 (3840cc432267ef020ce324a4ebf1ada264082bdf): 380 MB
  • T-5 (0f69bb578fa3e1118657d33f7cfcff8035591d41): 380 MB
  • T-4 (ccd26a535e49a9b009b9a5670ce58682ac43368b): 380 MB
  • T-3 (68665492916e56ee41e953293087bc17a016567a): 380 MB
  • T-2 (6a16b6eb8d10236bf8c111993892516c38fbe7a1): 380 MB
  • T-1 (1fd0c2c3ce51457e52c8ab4fe922b6c4404917f1): 380 MB
  • T (current commit): 274 MB

github-actions[bot] avatar Mar 02 '22 04:03 github-actions[bot]

@sgrove what is the status of this PR?

erezrokah avatar Mar 25 '22 10:03 erezrokah

@erezrokah It's still a WIP with some changes that have to happen on Netlify's frontend and a new build plugin.

sgrove avatar Mar 25 '22 14:03 sgrove

@sgrove Is this still valid? Or can we close this PR?

danez avatar Apr 14 '23 15:04 danez

Go ahead and close it

On Fri, Apr 14, 2023 at 8:20 AM Daniel Tschinder @.***> wrote:

@sgrove https://github.com/sgrove Is this still valid? Or can we close this PR?

— Reply to this email directly, view it on GitHub https://github.com/netlify/cli/pull/4407#issuecomment-1508781407, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAITYFIDUHDHTMFUQWFHTLXBFTM7ANCNFSM5PWFOTJQ . You are receiving this because you were mentioned.Message ID: @.***>

sgrove avatar Apr 14 '23 16:04 sgrove