cli icon indicating copy to clipboard operation
cli copied to clipboard

chore(deps): find a replacement to the `tabtab` dependency, so we can upgrade `inquirer`

Open erezrokah opened this issue 3 years ago • 4 comments

We would like to upgrade inquirer to the latest version.

However doing so will increase our package size significantly since tabtab still references an old inquirer version, so by upgrading inquirer it will no longer get de-duped by npm.

See https://github.com/netlify/cli/pull/3960#issuecomment-1006826925

I opened a PR in tabtab to address the issue, but the repo seems to be unmaintained.

Another alternative is to use a new npm feature called overrides, but that only helps with npm>=8.3.0. See https://github.com/npm/cli/releases/tag/v8.3.0

cc @lukasholzer

erezrokah avatar Jan 07 '22 11:01 erezrokah

I also opened a patch https://github.com/mklabs/tabtab/pull/75 to reduce the package size since right now it's including its coverage folder and all kind of unneeded files.

XhmikosR avatar Jan 07 '22 14:01 XhmikosR

We should be able to use https://github.com/pnpm/tabtab and use enquirer, cc @XhmikosR

erezrokah avatar Feb 10 '22 15:02 erezrokah

Should probably update #3941 too later, but the above changes should slim down things a lot. Next biggest issue is TypeScript in precinct.

XhmikosR avatar Feb 10 '22 16:02 XhmikosR

Once this is done, we should re-try https://github.com/netlify/cli/pull/4354

erezrokah avatar Mar 02 '22 15:03 erezrokah