fix: improve types and remove path-exists dependency
๐ Thanks for submitting a pull request! ๐
Summary
Refactor the functions-utils package to fix linting & types and remove the external path-exists dependency.
For us to review and ship your PR efficiently, please perform the following steps:
- [ ] Open a bug/issue before writing your code ๐งโ๐ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐ฅ (e.g. incident related), you can skip this step.
- [X] Read the contribution guidelines ๐. This ensures your code follows our style guide and passes our tests.
- [X] Update or add tests (if any source code was changed or added) ๐งช
- [ ] Update or add documentation (if features were changed or added) ๐
- [ ] Make sure the status checks below are successful โ
A picture of a cute animal (not mandatory, but encouraged)
off topic: based on the logs, the nudge action expects comment-tag but the current workflow uses comment_tag. perhaps this param can be updated in the future?
and regarding the failing edge-bundler test - it should be unrelated to my changes.
off topic: based on the logs, the nudge action expects
comment-tagbut the current workflow usescomment_tag. perhaps this param can be updated in the future?
Thank you! I'll look into correcting this separate from your changes
and regarding the failing edge-bundler test - it should be unrelated to my changes.
Correct, we unfortunately have some flakiness in our test suite currently. I've cleared that red x up for you