build icon indicating copy to clipboard operation
build copied to clipboard

fix: improve types and remove path-exists dependency

Open outslept opened this issue 5 months ago โ€ข 2 comments

๐ŸŽ‰ Thanks for submitting a pull request! ๐ŸŽ‰

Summary

Refactor the functions-utils package to fix linting & types and remove the external path-exists dependency.


For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [X] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests.
  • [X] Update or add tests (if any source code was changed or added) ๐Ÿงช
  • [ ] Update or add documentation (if features were changed or added) ๐Ÿ“
  • [ ] Make sure the status checks below are successful โœ…

A picture of a cute animal (not mandatory, but encouraged)

image

outslept avatar Jul 12 '25 15:07 outslept

off topic: based on the logs, the nudge action expects comment-tag but the current workflow uses comment_tag. perhaps this param can be updated in the future?

and regarding the failing edge-bundler test - it should be unrelated to my changes.

outslept avatar Jul 12 '25 15:07 outslept

off topic: based on the logs, the nudge action expects comment-tag but the current workflow uses comment_tag. perhaps this param can be updated in the future?

Thank you! I'll look into correcting this separate from your changes

and regarding the failing edge-bundler test - it should be unrelated to my changes.

Correct, we unfortunately have some flakiness in our test suite currently. I've cleared that red x up for you

mrstork avatar Jul 12 '25 15:07 mrstork