build icon indicating copy to clipboard operation
build copied to clipboard

fix: remove node-fetch from js-client package

Open mrstork opened this issue 7 months ago โ€ข 5 comments

Summary

Redoing #6383 Part of FRB-1833

TODO: Error + Retry handling


For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [ ] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests.
  • [ ] Update or add tests (if any source code was changed or added) ๐Ÿงช
  • [ ] Update or add documentation (if features were changed or added) ๐Ÿ“
  • [ ] Make sure the status checks below are successful โœ…

A picture of a cute animal (not mandatory, but encouraged)

mrstork avatar May 23 '25 21:05 mrstork

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files. Consider converting them to TypeScript.

github-actions[bot] avatar May 24 '25 03:05 github-actions[bot]

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files. Consider converting them to TypeScript.

github-actions[bot] avatar May 28 '25 21:05 github-actions[bot]

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files. Consider converting them to TypeScript.

github-actions[bot] avatar Jun 05 '25 11:06 github-actions[bot]

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files. Consider converting them to TypeScript.

github-actions[bot] avatar Jun 05 '25 11:06 github-actions[bot]

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files. Consider converting them to TypeScript.

github-actions[bot] avatar Jun 09 '25 16:06 github-actions[bot]

This change is currently blocked by a feature still supported in our CLI which uses proxy/http agents. That feature would first need to be removed before this change could go through. Alternatively, we would need to build in support for it to continue working as it does today.

mrstork avatar Jun 24 '25 14:06 mrstork