build icon indicating copy to clipboard operation
build copied to clipboard

fix: merge feature flags with returned values from API to enrich flag availability in config

Open estephinson opened this issue 11 months ago โ€ข 1 comments

๐ŸŽ‰ Thanks for submitting a pull request! ๐ŸŽ‰

Summary

  • Ensures feature flags that have been returned by the API are available within the context of netlify-config

For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [ ] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests.
  • [ ] Update or add tests (if any source code was changed or added) ๐Ÿงช
  • [ ] Update or add documentation (if features were changed or added) ๐Ÿ“
  • [ ] Make sure the status checks below are successful โœ…

A picture of a cute animal (not mandatory, but encouraged)

estephinson avatar Sep 15 '23 11:09 estephinson

Can we add some tests?

I can't see an easy path to getting tests around this.

I've refactored to move the logic into getSiteInfo, but will be adding a single unit test to assert on that

estephinson avatar Sep 15 '23 11:09 estephinson