build icon indicating copy to clipboard operation
build copied to clipboard

chore: move some ava tests to typescript

Open Skn0tt opened this issue 1 year ago โ€ข 4 comments

Summary

I got prompted to move some files to TypeScript: https://github.com/netlify/build/pull/5136

This PR adds TS support to our Ava tests, and moves the first two test files to TS.


For us to review and ship your PR efficiently, please perform the following steps:

  • [ ] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [ ] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests.
  • [ ] Update or add tests (if any source code was changed or added) ๐Ÿงช
  • [ ] Update or add documentation (if features were changed or added) ๐Ÿ“
  • [ ] Make sure the status checks below are successful โœ…

A picture of a cute animal (not mandatory, but encouraged)

Skn0tt avatar Jul 06 '23 11:07 Skn0tt

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files. Consider converting them to TypeScript.

github-actions[bot] avatar Jul 06 '23 11:07 github-actions[bot]

I'm not sure if this is worth it, considering we might move stuff to vitest in the near future? Curious what you think @lukasholzer @danez.

Skn0tt avatar Jul 06 '23 11:07 Skn0tt

I think it is worth introducing typescritp on the tests here as well and partially migrating them. But tests seem to fail

lukasholzer avatar Jul 06 '23 12:07 lukasholzer

Interesting ๐Ÿค” The failing ones are the ones I didn't touch, so maybe the config isn't right.

Skn0tt avatar Jul 06 '23 12:07 Skn0tt