build
build copied to clipboard
chore: move some ava tests to typescript
Summary
I got prompted to move some files to TypeScript: https://github.com/netlify/build/pull/5136
This PR adds TS support to our Ava tests, and moves the first two test files to TS.
For us to review and ship your PR efficiently, please perform the following steps:
- [ ] Open a bug/issue before writing your code ๐งโ๐ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐ฅ (e.g. incident related), you can skip this step.
- [ ] Read the contribution guidelines ๐. This ensures your code follows our style guide and passes our tests.
- [ ] Update or add tests (if any source code was changed or added) ๐งช
- [ ] Update or add documentation (if features were changed or added) ๐
- [ ] Make sure the status checks below are successful โ
A picture of a cute animal (not mandatory, but encouraged)
This pull request adds or modifies JavaScript (.js
, .cjs
, .mjs
) files.
Consider converting them to TypeScript.
I'm not sure if this is worth it, considering we might move stuff to vitest in the near future? Curious what you think @lukasholzer @danez.
I think it is worth introducing typescritp on the tests here as well and partially migrating them. But tests seem to fail
Interesting ๐ค The failing ones are the ones I didn't touch, so maybe the config isn't right.