build icon indicating copy to clipboard operation
build copied to clipboard

Revisit Lint rules that enforce opinionated code styles like the heavy destruction of function arguments

Open lukasholzer opened this issue 1 year ago • 0 comments

To make it easier for developers to get started on the repository the coding style of heavily destructing everything makes it super difficult.

IMHO a lint rule should help to avoid a bug. If it not helps to avoid a bug we should discuss at leas on dropping it.

I know a specific style of coding is a good thing as it helps easier to navigate through a codebase but we need to differentiate between bike shedding and useful patterns.

If it makes the code better read able go for it. If it makes it harder to read or understand we should debate about dropping it.

This issue should be a research to find those rule that makes it super hard developing by enforcing a very special type of coding.

Mutations should be avoided for example but there is no black and white. Sometimes its needed so try to find a sweet spot of rules that are not harming the developer experience.

TODO

  • come up a list with lint rules that make it super hard to develop
  • prepare a list of lint rules that are enforcing just style but are negotiable
  • craft a better eslint config having typescript and esmodules in mind.

Out of Scope

  • migrating the codebase (I want to first discuss about the config before doing that change)

lukasholzer avatar Sep 20 '22 14:09 lukasholzer